From 46bfb4fd651ec513215c3943ec598119f2c8db6f Mon Sep 17 00:00:00 2001 From: Teriuihi Date: Sat, 13 Apr 2024 20:27:33 +0200 Subject: [PATCH] Replace printStackTrace with Logger.throwing in various classes The changes made in these classes are intended to improve error handling and visibility. Instead of simply printing the StackTrace, the Logger.throwing method is now used to send error messages to the logger in a more controlled manner. This should facilitate better error tracking and resolution. The affected classes include database, configuration, and quest implementation classes. --- .../altitudequests/config/AbstractConfig.java | 5 ++--- .../altitudequests/config/QuestsConfig.java | 12 ++++++------ .../alttd/altitudequests/database/Database.java | 16 +++++++--------- .../com/alttd/altitudequests/objects/Quest.java | 13 ++++++------- .../objects/quests/BreedMobsQuest.java | 2 +- .../objects/quests/CollectDropsQuest.java | 2 +- .../objects/quests/KillMobsQuest.java | 2 +- .../altitudequests/objects/quests/MineQuest.java | 2 +- .../objects/quests/OtherQuest.java | 2 +- .../com/alttd/altitudequests/util/LoadUser.java | 2 +- .../com/alttd/altitudequests/util/Logger.java | 4 ++++ 11 files changed, 31 insertions(+), 31 deletions(-) diff --git a/src/main/java/com/alttd/altitudequests/config/AbstractConfig.java b/src/main/java/com/alttd/altitudequests/config/AbstractConfig.java index bfbfb54..a2578f1 100644 --- a/src/main/java/com/alttd/altitudequests/config/AbstractConfig.java +++ b/src/main/java/com/alttd/altitudequests/config/AbstractConfig.java @@ -54,8 +54,7 @@ abstract class AbstractConfig { } catch (InvocationTargetException ex) { throw new RuntimeException(ex.getCause()); } catch (Exception ex) { - Logger.severe("Error invoking %.", method.toString()); - ex.printStackTrace(); + Logger.throwing(AbstractConfig.class.getName(), "readConfig", ex); } } } @@ -69,7 +68,7 @@ abstract class AbstractConfig { yaml.save(file); } catch (IOException ex) { Logger.severe("Could not save %.", file.toString()); - ex.printStackTrace(); + Logger.throwing(AbstractConfig.class.getName(), "save", ex); } } diff --git a/src/main/java/com/alttd/altitudequests/config/QuestsConfig.java b/src/main/java/com/alttd/altitudequests/config/QuestsConfig.java index 38eae08..f0a2d8f 100644 --- a/src/main/java/com/alttd/altitudequests/config/QuestsConfig.java +++ b/src/main/java/com/alttd/altitudequests/config/QuestsConfig.java @@ -1,4 +1,4 @@ -package com.alttd.altitudequests.config;; +package com.alttd.altitudequests.config; import com.alttd.altitudequests.objects.variants.BreedMobsQuestObject; import com.alttd.altitudequests.objects.variants.CollectDropsQuestObject; @@ -67,7 +67,7 @@ public class QuestsConfig extends AbstractConfig { Logger.info("Loaded Mine quest " + key); } catch (Exception e) { - e.printStackTrace(); + Logger.throwing(QuestsConfig.class.getName(), "loadMineQuest", e); } } MINE_QUEST_NAME = config.getString("mining.name", MINE_QUEST_NAME); @@ -106,7 +106,7 @@ public class QuestsConfig extends AbstractConfig { Logger.info("Loaded Kill mob quest " + key); } catch (Exception e) { - e.printStackTrace(); + Logger.throwing(QuestsConfig.class.getName(), "loadKillMobQuest", e); } } KILL_MOB_QUEST_NAME = config.getString("kill_mobs.name", KILL_MOB_QUEST_NAME); @@ -145,7 +145,7 @@ public class QuestsConfig extends AbstractConfig { Logger.info("Loaded Collect drops quest " + key); } catch (Exception e) { - e.printStackTrace(); + Logger.throwing(QuestsConfig.class.getName(), "loadCollectQuest", e); } } COLLECT_DROPS_QUEST_NAME = config.getString("collect_drops.name", COLLECT_DROPS_QUEST_NAME); @@ -195,7 +195,7 @@ public class QuestsConfig extends AbstractConfig { Logger.info("Loaded Collect drops quest " + key); } catch (Exception e) { - e.printStackTrace(); + Logger.throwing(QuestsConfig.class.getName(), "loadOtherQuests", e); } } OTHER_QUEST_NAME = config.getString("other.name", OTHER_QUEST_NAME); @@ -232,7 +232,7 @@ public class QuestsConfig extends AbstractConfig { Logger.info("Loaded Breed mob quest " + key); } catch (Exception e) { - e.printStackTrace(); + Logger.throwing(QuestsConfig.class.getName(), "loadBreedMobQuest", e); } } BREED_MOB_QUEST_NAME = config.getString("breed_mobs.name", BREED_MOB_QUEST_NAME); diff --git a/src/main/java/com/alttd/altitudequests/database/Database.java b/src/main/java/com/alttd/altitudequests/database/Database.java index d94c2e8..21f0b0c 100644 --- a/src/main/java/com/alttd/altitudequests/database/Database.java +++ b/src/main/java/com/alttd/altitudequests/database/Database.java @@ -32,7 +32,7 @@ public class Database { try { openConnection(); } catch (SQLException e) { - e.printStackTrace(); + Logger.throwing(Database.class.getName(), "init", e); } //Run all create table functions @@ -45,8 +45,7 @@ public class Database { } catch (InvocationTargetException ex) { throw new RuntimeException(ex.getCause()); } catch (Exception ex) { - Logger.severe("Error invoking %.", method.toString()); - ex.printStackTrace(); + Logger.throwing(Database.class.getName(), "init", ex); } } } @@ -69,7 +68,7 @@ public class Database { try { Class.forName("com.mysql.cj.jdbc.Driver"); } catch (ClassNotFoundException e) { - e.printStackTrace(); + Logger.throwing(Database.class.getName(), "openConnection", e); } connection = DriverManager.getConnection( @@ -83,7 +82,7 @@ public class Database { try { openConnection(); } catch (SQLException e) { - e.printStackTrace(); + Logger.throwing(Database.class.getName(), "getConnection", e); } return connection; } @@ -103,7 +102,7 @@ public class Database { ")"; getDatabase().getConnection().prepareStatement(sql).executeUpdate(); } catch (SQLException e) { - e.printStackTrace(); + Logger.throwing(Database.class.getName(), "createUserPointsTable", e); Logger.severe("Error while trying to create user point table"); Logger.severe("Shutting down AltitudeQuests"); Bukkit.getPluginManager().disablePlugin(AQuest.getInstance()); @@ -121,9 +120,8 @@ public class Database { ")"; getDatabase().getConnection().prepareStatement(sql).executeUpdate(); } catch (SQLException e) { - e.printStackTrace(); - Logger.severe("Error while trying to create quest log table"); - Logger.severe("Shutting down AltitudeQuests"); + Logger.throwing(Database.class.getName(), "createQuestLogTable", e); + Logger.severe("Error while trying to create quest log table\nShutting down AltitudeQuests"); Bukkit.getPluginManager().disablePlugin(AQuest.getInstance()); } } diff --git a/src/main/java/com/alttd/altitudequests/objects/Quest.java b/src/main/java/com/alttd/altitudequests/objects/Quest.java index dfff39a..80e454a 100644 --- a/src/main/java/com/alttd/altitudequests/objects/Quest.java +++ b/src/main/java/com/alttd/altitudequests/objects/Quest.java @@ -109,7 +109,7 @@ public abstract class Quest { if (resultSet.next()) return resultSet.getInt("total"); } catch (SQLException exception) { - exception.printStackTrace(); + Logger.throwing(Quest.class.getName(), "loadQuestsDoneThisMonth", exception); } return 0; } @@ -127,11 +127,11 @@ public abstract class Quest { } catch (InvocationTargetException | IllegalAccessException | InstantiationException | NoSuchMethodException e) { player.sendMiniMessage("Unable to create quest, contact an admin", null); - e.printStackTrace(); + Logger.throwing(Quest.class.getName(), "createDailyQuest", e); Logger.severe("% does not have a constructor with a Player input or has improper access.", questClass.getName()); } catch (Exception e) { player.sendMiniMessage("Unable to create quest, contact an admin", null); - e.printStackTrace(); + Logger.throwing(Quest.class.getName(), "createDailyQuest", e); Logger.severe("% could not be created due to invalid namespace key or variant.", questClass.getName()); } } @@ -198,7 +198,7 @@ public abstract class Quest { putDailyQuest(uuid, quest1); } catch (NoSuchMethodException | IllegalAccessException | InstantiationException | InvocationTargetException e) { - e.printStackTrace(); + Logger.throwing(Quest.class.getName(), "loadDailyQuest", e); return false; } return true; @@ -281,9 +281,8 @@ public abstract class Quest { if (Config.DEBUG) Logger.info("% finished their quest", uuidString); } catch (SQLException e) { - e.printStackTrace(); - Logger.severe("Error while trying to create quest log table"); - Logger.severe("Shutting down AltitudeQuests"); + Logger.throwing(Quest.class.getName(), "saveDone", e); + Logger.severe("Error while trying to create quest log table\nShutting down AltitudeQuests"); Bukkit.getPluginManager().disablePlugin(AQuest.getInstance()); } } diff --git a/src/main/java/com/alttd/altitudequests/objects/quests/BreedMobsQuest.java b/src/main/java/com/alttd/altitudequests/objects/quests/BreedMobsQuest.java index 50644e9..2ff5a8b 100644 --- a/src/main/java/com/alttd/altitudequests/objects/quests/BreedMobsQuest.java +++ b/src/main/java/com/alttd/altitudequests/objects/quests/BreedMobsQuest.java @@ -82,7 +82,7 @@ public class BreedMobsQuest extends Quest { statement.setInt(15, isRewardReceived() ? 1 : 0); statement.execute(); } catch (SQLException exception) { - exception.printStackTrace(); + Logger.throwing(BreedMobsQuest.class.getName(), "save", exception); } } diff --git a/src/main/java/com/alttd/altitudequests/objects/quests/CollectDropsQuest.java b/src/main/java/com/alttd/altitudequests/objects/quests/CollectDropsQuest.java index 3446a82..f954583 100644 --- a/src/main/java/com/alttd/altitudequests/objects/quests/CollectDropsQuest.java +++ b/src/main/java/com/alttd/altitudequests/objects/quests/CollectDropsQuest.java @@ -86,7 +86,7 @@ public class CollectDropsQuest extends Quest { statement.setInt(15, isRewardReceived() ? 1 : 0); statement.execute(); } catch (SQLException exception) { - exception.printStackTrace(); + Logger.throwing(CollectDropsQuest.class.getName(), "save", exception); } } diff --git a/src/main/java/com/alttd/altitudequests/objects/quests/KillMobsQuest.java b/src/main/java/com/alttd/altitudequests/objects/quests/KillMobsQuest.java index 87ffc74..8f318c4 100644 --- a/src/main/java/com/alttd/altitudequests/objects/quests/KillMobsQuest.java +++ b/src/main/java/com/alttd/altitudequests/objects/quests/KillMobsQuest.java @@ -83,7 +83,7 @@ public class KillMobsQuest extends Quest { statement.setInt(15, isRewardReceived() ? 1 : 0); statement.execute(); } catch (SQLException exception) { - exception.printStackTrace(); + Logger.throwing(KillMobsQuest.class.getName(), "save", exception); } } diff --git a/src/main/java/com/alttd/altitudequests/objects/quests/MineQuest.java b/src/main/java/com/alttd/altitudequests/objects/quests/MineQuest.java index 431e865..983ac0d 100644 --- a/src/main/java/com/alttd/altitudequests/objects/quests/MineQuest.java +++ b/src/main/java/com/alttd/altitudequests/objects/quests/MineQuest.java @@ -86,7 +86,7 @@ public class MineQuest extends Quest { statement.setInt(15, isRewardReceived() ? 1 : 0); statement.execute(); } catch (SQLException exception) { - exception.printStackTrace(); + Logger.throwing(MineQuest.class.getName(), "save", exception); } } diff --git a/src/main/java/com/alttd/altitudequests/objects/quests/OtherQuest.java b/src/main/java/com/alttd/altitudequests/objects/quests/OtherQuest.java index 0a5de0f..948ee57 100644 --- a/src/main/java/com/alttd/altitudequests/objects/quests/OtherQuest.java +++ b/src/main/java/com/alttd/altitudequests/objects/quests/OtherQuest.java @@ -88,7 +88,7 @@ public class OtherQuest extends Quest { statement.setInt(15, isRewardReceived() ? 1 : 0); statement.execute(); } catch (SQLException exception) { - exception.printStackTrace(); + Logger.throwing(OtherQuest.class.getName(), "save", exception); } } diff --git a/src/main/java/com/alttd/altitudequests/util/LoadUser.java b/src/main/java/com/alttd/altitudequests/util/LoadUser.java index bead779..9899021 100644 --- a/src/main/java/com/alttd/altitudequests/util/LoadUser.java +++ b/src/main/java/com/alttd/altitudequests/util/LoadUser.java @@ -42,7 +42,7 @@ public class LoadUser extends BukkitRunnable { Logger.warning("Unable to load quest for %, creating new quest...", uuid.toString()); } } catch (SQLException exception) { - exception.printStackTrace(); + Logger.throwing(LoadUser.class.getName(), "run", exception); } if (Config.DEBUG) Logger.info("Creating new daily quest for %", uuid.toString()); diff --git a/src/main/java/com/alttd/altitudequests/util/Logger.java b/src/main/java/com/alttd/altitudequests/util/Logger.java index 2c8a3a7..6856fc3 100644 --- a/src/main/java/com/alttd/altitudequests/util/Logger.java +++ b/src/main/java/com/alttd/altitudequests/util/Logger.java @@ -33,4 +33,8 @@ public class Logger { } logger.severe(severe); } + + public static void throwing(String sourceClass, String sourceMethod, Exception e) { + logger.throwing(sourceClass, sourceMethod, e); + } }