From 1d76895cbb8daea031f9703d5330920c50420836 Mon Sep 17 00:00:00 2001 From: akastijn Date: Sun, 23 Nov 2025 05:03:42 +0100 Subject: [PATCH] Prevent username retrieval if user is not authenticated and fix variable naming in `DiscordAppealMapper`. --- .../altitudeweb/database/web_db/forms/DiscordAppealMapper.java | 2 +- frontend/src/app/services/auth.service.ts | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/database/src/main/java/com/alttd/altitudeweb/database/web_db/forms/DiscordAppealMapper.java b/database/src/main/java/com/alttd/altitudeweb/database/web_db/forms/DiscordAppealMapper.java index e42302e..9177033 100644 --- a/database/src/main/java/com/alttd/altitudeweb/database/web_db/forms/DiscordAppealMapper.java +++ b/database/src/main/java/com/alttd/altitudeweb/database/web_db/forms/DiscordAppealMapper.java @@ -11,7 +11,7 @@ public interface DiscordAppealMapper { @Insert(""" INSERT INTO discord_appeals (uuid, discord_id, discord_username, reason, created_at, send_at, e_mail, assigned_to) - VALUES (#{uuid}, #{discord_id}, #{discord_username}, #{reason}, #{createdAt}, #{sendAt}, #{email}, #{assignedTo}) + VALUES (#{uuid}, #{discordId}, #{discordUsername}, #{reason}, #{createdAt}, #{sendAt}, #{email}, #{assignedTo}) """) void createDiscordAppeal(DiscordAppeal discordAppeal); diff --git a/frontend/src/app/services/auth.service.ts b/frontend/src/app/services/auth.service.ts index e8e44b4..ac7cabf 100644 --- a/frontend/src/app/services/auth.service.ts +++ b/frontend/src/app/services/auth.service.ts @@ -53,6 +53,9 @@ export class AuthService { console.log("Reloading username for localhost"); this._username.set('developer'); } + if (!this.isAuthenticated$()) { + return; + } this.loginService.getUsername().subscribe({ next: (username) => { console.log("Username retrieved: " + username.username);