From 300d33da7d979fe7fa1428a531f2c071e9be50ef Mon Sep 17 00:00:00 2001
From: akastijn <akastijn@alttd.com>
Date: Sat, 18 Oct 2025 23:10:56 +0200
Subject: [PATCH] Prevent duplicate staff application submissions by disabling
 the submit button during processing.

---
 .../staff-application.component.html          |  2 +-
 .../staff-application.component.ts            | 31 ++++++++++++++-----
 2 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/frontend/src/app/pages/forms/staff-application/staff-application.component.html b/frontend/src/app/pages/forms/staff-application/staff-application.component.html
index 0d53b43..9ac18fd 100644
--- a/frontend/src/app/pages/forms/staff-application/staff-application.component.html
+++ b/frontend/src/app/pages/forms/staff-application/staff-application.component.html
@@ -287,7 +287,7 @@
                     </mat-form-field>
                   </div>
                   <button mat-raised-button (click)="onSubmit()"
-                          [disabled]="isFormInvalid()">
+                          [disabled]="isFormInvalid() || isSubmitting()">
                     Submit Application
                   </button>
                 </section>
diff --git a/frontend/src/app/pages/forms/staff-application/staff-application.component.ts b/frontend/src/app/pages/forms/staff-application/staff-application.component.ts
index 36c3260..0a87833 100644
--- a/frontend/src/app/pages/forms/staff-application/staff-application.component.ts
+++ b/frontend/src/app/pages/forms/staff-application/staff-application.component.ts
@@ -57,6 +57,7 @@ export class StaffApplicationComponent implements OnInit, OnDestroy, AfterViewIn
   public staffApplicationService = inject(ApplicationsService)
   private resizeObserver: ResizeObserver | null = null;
   private boundHandleResize: any;
+  protected isSubmitting = signal<boolean>(false);
 
   protected form: FormGroup<StaffApplicationForm>;
   private emails = signal<EmailEntry[]>([]);
@@ -219,9 +220,11 @@ export class StaffApplicationComponent implements OnInit, OnDestroy, AfterViewIn
   }
 
   public onSubmit() {
+    this.isSubmitting.set(true);
     if (this.form === undefined) {
       console.error('Form is undefined');
       this.matSnackBar.open('An error occurred, please try again later')
+      this.isSubmitting.set(false);
       return
     }
     if (this.form.valid) {
@@ -233,6 +236,7 @@ export class StaffApplicationComponent implements OnInit, OnDestroy, AfterViewIn
         control?.markAsTouched();
       });
       this.matSnackBar.open('Please fill out all required fields')
+      this.isSubmitting.set(false);
     }
   }
 
@@ -246,14 +250,27 @@ export class StaffApplicationComponent implements OnInit, OnDestroy, AfterViewIn
   private sendForm() {
     const staffApplication: StaffApplication = this.mapToStaffApplication(this.form.getRawValue());
 
-    this.staffApplicationService.submitStaffApplication(staffApplication).subscribe(result => {
-      if (!result.verified_mail) {
-        throw new Error('Submitted a form with an e-mail that was not verified.');
+    this.staffApplicationService.submitStaffApplication(staffApplication).subscribe({
+      next: result => {
+        if (!result.verified_mail) {
+          this.isSubmitting.set(false);
+          this.matSnackBar.open('Your email has not been verified. Please verify your email before submitting.', 'Close', {
+            duration: 5000
+          });
+          return;
+        }
+        this.router.navigate(['/forms/sent'], {
+          state: {message: result.message}
+        }).then();
+      },
+      error: (error) => {
+        this.isSubmitting.set(false);
+        console.error('Error submitting application:', error);
+        this.matSnackBar.open('An error occurred while submitting your application. Please try again later.', 'Close', {
+          duration: 5000
+        });
       }
-      this.router.navigate(['/forms/sent'], {
-        state: {message: result.message}
-      }).then();
-    })
+    });
   }
 
   public currentPageIndex: number = 0;