From 9622eea43479d077e9f72bcced4c45ba507ee847 Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 20 Sep 2020 12:06:53 -0400 Subject: [PATCH] StringBuilder#append should not contain concatenation (#1020) --- .../GriefPrevention/BlockEventHandler.java | 2 +- .../GriefPrevention/CustomLogger.java | 2 +- .../GriefPrevention/GriefPrevention.java | 18 +++++++++--------- .../GriefPrevention/PlayerEventHandler.java | 4 ++-- .../GriefPrevention/WordFinder.java | 2 +- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java b/src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java index 4780e91..7a5607b 100644 --- a/src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java +++ b/src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java @@ -147,7 +147,7 @@ public class BlockEventHandler implements Listener if (!withoutSpaces.isEmpty()) { notEmpty = true; - lines.append("\n " + event.getLine(i)); + lines.append("\n ").append(event.getLine(i)); } } diff --git a/src/main/java/me/ryanhamshire/GriefPrevention/CustomLogger.java b/src/main/java/me/ryanhamshire/GriefPrevention/CustomLogger.java index 1397452..f93821a 100644 --- a/src/main/java/me/ryanhamshire/GriefPrevention/CustomLogger.java +++ b/src/main/java/me/ryanhamshire/GriefPrevention/CustomLogger.java @@ -75,7 +75,7 @@ class CustomLogger Matcher matcher = inlineFormatterPattern.matcher(entry); entry = matcher.replaceAll(""); String timestamp = this.timestampFormat.format(new Date()); - this.queuedEntries.append(timestamp + " " + entry + "\n"); + this.queuedEntries.append(timestamp).append(' ').append(entry).append('\n'); } private boolean isEnabledType(CustomLogEntryTypes entryType) diff --git a/src/main/java/me/ryanhamshire/GriefPrevention/GriefPrevention.java b/src/main/java/me/ryanhamshire/GriefPrevention/GriefPrevention.java index e06a703..5ea0e80 100644 --- a/src/main/java/me/ryanhamshire/GriefPrevention/GriefPrevention.java +++ b/src/main/java/me/ryanhamshire/GriefPrevention/GriefPrevention.java @@ -1495,42 +1495,42 @@ public class GriefPrevention extends JavaPlugin GriefPrevention.sendMessage(player, TextMode.Info, Messages.TrustListHeader); StringBuilder permissions = new StringBuilder(); - permissions.append(ChatColor.GOLD + ">"); + permissions.append(ChatColor.GOLD).append('>'); if (managers.size() > 0) { for (String manager : managers) - permissions.append(this.trustEntryToPlayerName(manager) + " "); + permissions.append(this.trustEntryToPlayerName(manager)).append(' '); } player.sendMessage(permissions.toString()); permissions = new StringBuilder(); - permissions.append(ChatColor.YELLOW + ">"); + permissions.append(ChatColor.YELLOW).append('>'); if (builders.size() > 0) { for (String builder : builders) - permissions.append(this.trustEntryToPlayerName(builder) + " "); + permissions.append(this.trustEntryToPlayerName(builder)).append(' '); } player.sendMessage(permissions.toString()); permissions = new StringBuilder(); - permissions.append(ChatColor.GREEN + ">"); + permissions.append(ChatColor.GREEN).append('>'); if (containers.size() > 0) { for (String container : containers) - permissions.append(this.trustEntryToPlayerName(container) + " "); + permissions.append(this.trustEntryToPlayerName(container)).append(' '); } player.sendMessage(permissions.toString()); permissions = new StringBuilder(); - permissions.append(ChatColor.BLUE + ">"); + permissions.append(ChatColor.BLUE).append('>'); if (accessors.size() > 0) { for (String accessor : accessors) - permissions.append(this.trustEntryToPlayerName(accessor) + " "); + permissions.append(this.trustEntryToPlayerName(accessor)).append(' '); } player.sendMessage(permissions.toString()); @@ -2399,7 +2399,7 @@ public class GriefPrevention extends JavaPlugin PlayerData playerData = this.dataStore.getPlayerData(playerID); playerData.setBonusClaimBlocks(playerData.getBonusClaimBlocks() + adjustment); this.dataStore.savePlayerData(playerID, playerData); - builder.append(onlinePlayer.getName() + " "); + builder.append(onlinePlayer.getName()).append(' '); } GriefPrevention.sendMessage(player, TextMode.Success, Messages.AdjustBlocksAllSuccess, String.valueOf(adjustment)); diff --git a/src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java b/src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java index 8f289f5..c361ba7 100644 --- a/src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java +++ b/src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java @@ -502,7 +502,7 @@ class PlayerEventHandler implements Listener StringBuilder builder = new StringBuilder(); for (String arg : args) { - builder.append(arg + " "); + builder.append(arg).append(' '); } makeSocialLogEntry(event.getPlayer().getName(), builder.toString()); @@ -611,7 +611,7 @@ class PlayerEventHandler implements Listener { entryBuilder.append(' '); } - entryBuilder.append(": " + message); + entryBuilder.append(": ").append(message); longestNameLength = Math.max(longestNameLength, name.length()); //TODO: cleanup static diff --git a/src/main/java/me/ryanhamshire/GriefPrevention/WordFinder.java b/src/main/java/me/ryanhamshire/GriefPrevention/WordFinder.java index a1ad84b..a30b7ec 100644 --- a/src/main/java/me/ryanhamshire/GriefPrevention/WordFinder.java +++ b/src/main/java/me/ryanhamshire/GriefPrevention/WordFinder.java @@ -17,7 +17,7 @@ class WordFinder { if (!word.isEmpty() && !word.trim().isEmpty()) { - patternBuilder.append("|(([^\\w]|^)" + Pattern.quote(word) + "([^\\w]|$))"); + patternBuilder.append("|(([^\\w]|^)").append(Pattern.quote(word)).append("([^\\w]|$))"); } }