From d53ba82e3e7cc95cd3f8d3caa2f1dcf82bd91232 Mon Sep 17 00:00:00 2001
From: Teriuihi <teriuihi@alttd.com>
Date: Tue, 6 Aug 2024 22:21:30 +0200
Subject: [PATCH] Refactor HTML generation in ContactFormData

Extract the HTML generation logic to a reusable method in the Form class. This change reduces code duplication and enhances maintainability by centralizing the table generation functionality.
---
 .../alttd/forms/contact/ContactFormData.java  | 19 +------------------
 src/main/java/com/alttd/forms/form/Form.java  | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/src/main/java/com/alttd/forms/contact/ContactFormData.java b/src/main/java/com/alttd/forms/contact/ContactFormData.java
index d006104..a73cebd 100644
--- a/src/main/java/com/alttd/forms/contact/ContactFormData.java
+++ b/src/main/java/com/alttd/forms/contact/ContactFormData.java
@@ -38,26 +38,9 @@ public class ContactFormData extends Form {
 
     @Override
     public String toHtml() {
-        StringBuilder htmlOutput = new StringBuilder();
-
-        htmlOutput.append("<table style='border-collapse: collapse; width: 100%;'>");
-
         String[] fields = {"Username", "Email", "Question"};
         String[] values = {username, email, question};
 
-        for (int i = 0; i < fields.length; i++) {
-            htmlOutput.append("<tr style='border: 1px solid #ddd;'>");
-            htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px; font-weight: bold;'>");
-            htmlOutput.append(fields[i]);
-            htmlOutput.append("</td>");
-            htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px;'>");
-            htmlOutput.append(values[i]);
-            htmlOutput.append("</td>");
-            htmlOutput.append("</tr>");
-        }
-
-        htmlOutput.append("</table>");
-
-        return htmlOutput.toString();
+        return toHtml(fields, values);
     }
 }
\ No newline at end of file
diff --git a/src/main/java/com/alttd/forms/form/Form.java b/src/main/java/com/alttd/forms/form/Form.java
index fad5c2e..6857786 100644
--- a/src/main/java/com/alttd/forms/form/Form.java
+++ b/src/main/java/com/alttd/forms/form/Form.java
@@ -10,6 +10,25 @@ public abstract class Form {
 
     public abstract String toHtml();
 
+    public String toHtml(String[] fields, String[] values) {
+        StringBuilder htmlOutput = new StringBuilder();
+        htmlOutput.append("<table style='border-collapse: collapse; width: 100%;'>");
+        for (int i = 0; i < fields.length; i++) {
+            htmlOutput.append("<tr style='border: 1px solid #ddd;'>");
+            htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px; font-weight: bold;'>");
+            htmlOutput.append(fields[i]);
+            htmlOutput.append("</td>");
+            htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px;'>");
+            htmlOutput.append(values[i]);
+            htmlOutput.append("</td>");
+            htmlOutput.append("</tr>");
+        }
+
+        htmlOutput.append("</table>");
+
+        return htmlOutput.toString();
+    }
+
     @Override
     public abstract String toString();
 }