refactor #2

2024-04-13T18:56:19Z

stijn commented

2024-04-13 18:56:19 +00:00

Refactored AQuest, went through all the IDE warnings and resolved all code related ones. Grammar and spelling were left unchecked.

stijn added 4 commits 2024-04-13 18:56:19 +00:00

Replace printStackTrace with Logger.throwing in various classes 46bfb4fd65

The changes made in these classes are intended to improve error handling and visibility. Instead of simply printing the StackTrace, the Logger.throwing method is now used to send error messages to the logger in a more controlled manner. This should facilitate better error tracking and resolution. The affected classes include database, configuration, and quest implementation classes.

Remove commented code and ensure async execution in specific methods c6b186e2c6

All code sections that were commented out are now completely removed, resulting in a cleaner and more efficient codebase. In addition, the method 'unloadUser' in the Quest class, which previously only included a comment suggesting it should be run as an async operation, is now forced to run in an asynchronous manner, potentially improving performance.

Optimize and cleanup various classes 3bb822b41c

Reformatted several classes for optimization purposes. This includes removing unnecessary try-catch blocks, redundant initializers and imports, and condensing confirmation checks. Additionally, updated the `Database` class's `createUserPointsTable` and `createQuestLogTable` methods to use try-with-resources to ensure proper resource management.

Refactor quest saving, update Galaxy-API version 34c5252db4

Quest saving logic was abstracted into a saveQuest method in the Quest class to avoid redundancy. This change was reflected in OtherQuest, MineQuest, BreedMobsQuest, KillMobsQuest and CollectDropsQuest classes. Additionally, the Galaxy-API version was updated in the build.gradle.kts file.

stijn added spent time 1 hour 20 minutes

2024-04-13 18:56:46 +00:00

destro was assigned by stijn

2024-04-13 18:56:53 +00:00

stijn self-assigned this 2024-04-13 18:57:03 +00:00

destro was unassigned by stijn

2024-04-13 18:57:03 +00:00

stijn requested review from destro 2024-04-13 18:57:07 +00:00

stijn added 1 commit 2024-04-18 18:49:12 +00:00

Add new responses to handle quest reroll situations 81ed73fbd1

This commit fixes a bug where the quest reroll feature could be used repeatedly without restrictions. Now, appropriate responses will be given in cases where the quest is still loading or if the daily quest has already been completed. This ensures that the player cannot misuse the reroll functionality.

stijn added 1 commit 2024-07-19 23:46:39 +00:00

Update file paths in quest configurations ffd67eada8

The file paths previously pointed to the user home directory. This commit adjusts the paths to consistently use a mount point directory instead. The change affects the 'QuestsConfig', 'Config', 'MessagesConfig', and 'DatabaseConfig' classes.

stijn added 1 commit 2025-06-28 01:33:45 +00:00

Update to java 21, 1.21 with cosmso ff4fb6c1ae

This branch is already included in the target branch. There is nothing to merge.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin refactor:refactor

git checkout refactor

Sign in to join this conversation.

1 Participants

Notifications

Total Time Spent: 1 hour 20 minutes

stijn

1 hour 20 minutes

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Altitude/AltitudeQuests#2