Altitude/AlttdGriefPrevention
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

StringBuilder#append should not contain concatenation (#1020)

Browse Source
This commit is contained in:
Adam 2020-09-20 12:06:53 -04:00 committed by GitHub
parent 26124d3dee
commit 9622eea434
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/me/ryanhamshire/GriefPrevention/BlockEventHandler.java
View File

@ -147,7 +147,7 @@ public class BlockEventHandler implements Listener
if (!withoutSpaces.isEmpty()) if (!withoutSpaces.isEmpty())
{ {
notEmpty = true; notEmpty = true;
lines.append("\n " + event.getLine(i)); lines.append("\n ").append(event.getLine(i));
} }
} }

2
src/main/java/me/ryanhamshire/GriefPrevention/CustomLogger.java
View File

@ -75,7 +75,7 @@ class CustomLogger
Matcher matcher = inlineFormatterPattern.matcher(entry); Matcher matcher = inlineFormatterPattern.matcher(entry);
entry = matcher.replaceAll(""); entry = matcher.replaceAll("");
String timestamp = this.timestampFormat.format(new Date()); String timestamp = this.timestampFormat.format(new Date());
this.queuedEntries.append(timestamp + " " + entry + "\n"); this.queuedEntries.append(timestamp).append(' ').append(entry).append('\n');
} }
private boolean isEnabledType(CustomLogEntryTypes entryType) private boolean isEnabledType(CustomLogEntryTypes entryType)

18
src/main/java/me/ryanhamshire/GriefPrevention/GriefPrevention.java
View File

@ -1495,42 +1495,42 @@ public class GriefPrevention extends JavaPlugin
GriefPrevention.sendMessage(player, TextMode.Info, Messages.TrustListHeader); GriefPrevention.sendMessage(player, TextMode.Info, Messages.TrustListHeader);
StringBuilder permissions = new StringBuilder(); StringBuilder permissions = new StringBuilder();
permissions.append(ChatColor.GOLD + ">"); permissions.append(ChatColor.GOLD).append('>');
if (managers.size() > 0) if (managers.size() > 0)
{ {
for (String manager : managers) for (String manager : managers)
permissions.append(this.trustEntryToPlayerName(manager) + " "); permissions.append(this.trustEntryToPlayerName(manager)).append(' ');
} }
player.sendMessage(permissions.toString()); player.sendMessage(permissions.toString());
permissions = new StringBuilder(); permissions = new StringBuilder();
permissions.append(ChatColor.YELLOW + ">"); permissions.append(ChatColor.YELLOW).append('>');
if (builders.size() > 0) if (builders.size() > 0)
{ {
for (String builder : builders) for (String builder : builders)
permissions.append(this.trustEntryToPlayerName(builder) + " "); permissions.append(this.trustEntryToPlayerName(builder)).append(' ');
} }
player.sendMessage(permissions.toString()); player.sendMessage(permissions.toString());
permissions = new StringBuilder(); permissions = new StringBuilder();
permissions.append(ChatColor.GREEN + ">"); permissions.append(ChatColor.GREEN).append('>');
if (containers.size() > 0) if (containers.size() > 0)
{ {
for (String container : containers) for (String container : containers)
permissions.append(this.trustEntryToPlayerName(container) + " "); permissions.append(this.trustEntryToPlayerName(container)).append(' ');
} }
player.sendMessage(permissions.toString()); player.sendMessage(permissions.toString());
permissions = new StringBuilder(); permissions = new StringBuilder();
permissions.append(ChatColor.BLUE + ">"); permissions.append(ChatColor.BLUE).append('>');
if (accessors.size() > 0) if (accessors.size() > 0)
{ {
for (String accessor : accessors) for (String accessor : accessors)
permissions.append(this.trustEntryToPlayerName(accessor) + " "); permissions.append(this.trustEntryToPlayerName(accessor)).append(' ');
} }
player.sendMessage(permissions.toString()); player.sendMessage(permissions.toString());
@ -2399,7 +2399,7 @@ public class GriefPrevention extends JavaPlugin
PlayerData playerData = this.dataStore.getPlayerData(playerID); PlayerData playerData = this.dataStore.getPlayerData(playerID);
playerData.setBonusClaimBlocks(playerData.getBonusClaimBlocks() + adjustment); playerData.setBonusClaimBlocks(playerData.getBonusClaimBlocks() + adjustment);
this.dataStore.savePlayerData(playerID, playerData); this.dataStore.savePlayerData(playerID, playerData);
builder.append(onlinePlayer.getName() + " "); builder.append(onlinePlayer.getName()).append(' ');
} }
GriefPrevention.sendMessage(player, TextMode.Success, Messages.AdjustBlocksAllSuccess, String.valueOf(adjustment)); GriefPrevention.sendMessage(player, TextMode.Success, Messages.AdjustBlocksAllSuccess, String.valueOf(adjustment));

4
src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java
View File

@ -502,7 +502,7 @@ class PlayerEventHandler implements Listener
StringBuilder builder = new StringBuilder(); StringBuilder builder = new StringBuilder();
for (String arg : args) for (String arg : args)
{ {
builder.append(arg + " "); builder.append(arg).append(' ');
} }
makeSocialLogEntry(event.getPlayer().getName(), builder.toString()); makeSocialLogEntry(event.getPlayer().getName(), builder.toString());
@ -611,7 +611,7 @@ class PlayerEventHandler implements Listener
{ {
entryBuilder.append(' '); entryBuilder.append(' ');
} }
entryBuilder.append(": " + message); entryBuilder.append(": ").append(message);
longestNameLength = Math.max(longestNameLength, name.length()); longestNameLength = Math.max(longestNameLength, name.length());
//TODO: cleanup static //TODO: cleanup static

2
src/main/java/me/ryanhamshire/GriefPrevention/WordFinder.java
View File

@ -17,7 +17,7 @@ class WordFinder
{ {
if (!word.isEmpty() && !word.trim().isEmpty()) if (!word.isEmpty() && !word.trim().isEmpty())
{ {
patternBuilder.append("|(([^\\w]|^)" + Pattern.quote(word) + "([^\\w]|$))"); patternBuilder.append("|(([^\\w]|^)").append(Pattern.quote(word)).append("([^\\w]|$))");
} }
} }