Altitude/SiteBackend
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor HTML generation in ContactFormData

Browse Source 
Extract the HTML generation logic to a reusable method in the Form class. This change reduces code duplication and enhances maintainability by centralizing the table generation functionality.
This commit is contained in:
Teriuihi 2024-08-06 22:21:30 +02:00
parent ac5448385d
commit d53ba82e3e
2 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/main/java/com/alttd/forms/contact/ContactFormData.java
View File

@ -38,26 +38,9 @@ public class ContactFormData extends Form {
@Override @Override
public String toHtml() { public String toHtml() {
StringBuilder htmlOutput = new StringBuilder();
htmlOutput.append("<table style='border-collapse: collapse; width: 100%;'>");
String[] fields = {"Username", "Email", "Question"}; String[] fields = {"Username", "Email", "Question"};
String[] values = {username, email, question}; String[] values = {username, email, question};
for (int i = 0; i < fields.length; i++) { return toHtml(fields, values);
htmlOutput.append("<tr style='border: 1px solid #ddd;'>");
htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px; font-weight: bold;'>");
htmlOutput.append(fields[i]);
htmlOutput.append("</td>");
htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px;'>");
htmlOutput.append(values[i]);
htmlOutput.append("</td>");
htmlOutput.append("</tr>");
}
htmlOutput.append("</table>");
return htmlOutput.toString();
} }
} }

19
src/main/java/com/alttd/forms/form/Form.java
View File

@ -10,6 +10,25 @@ public abstract class Form {
public abstract String toHtml(); public abstract String toHtml();
public String toHtml(String[] fields, String[] values) {
StringBuilder htmlOutput = new StringBuilder();
htmlOutput.append("<table style='border-collapse: collapse; width: 100%;'>");
for (int i = 0; i < fields.length; i++) {
htmlOutput.append("<tr style='border: 1px solid #ddd;'>");
htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px; font-weight: bold;'>");
htmlOutput.append(fields[i]);
htmlOutput.append("</td>");
htmlOutput.append("<td style='border: 1px solid #ddd; padding: 10px;'>");
htmlOutput.append(values[i]);
htmlOutput.append("</td>");
htmlOutput.append("</tr>");
}
htmlOutput.append("</table>");
return htmlOutput.toString();
}
@Override @Override
public abstract String toString(); public abstract String toString();
} }